Picker: omnibox URL bar, width cap, and wrapped URL#246
Merged
Conversation
- Add theme brushes for a light address strip (favicon + URL) in light and dark mode. - Cap root grid MaxWidth during SizeToContent so long URLs do not inflate the window. - Lay out URL in a grid with top-aligned favicon; wrap text with a modest MaxHeight and ellipsis. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores a browser-like light strip for the favicon + URL on the picker, keeps long URLs from blowing out
SizeToContentwindow width, and shows the URL wrapped (with a height cap and ellipsis) instead of a single truncated line.Changes
UrlBar*dynamic brushes inApp.xaml.cs(and design-time entries inApp.xaml) so the address area stays a light omnibox in both themes.PickerUrlBarMaxWidthConvertercaps the rootGridMaxWidthfrom the window width / work area so measure pass does not use the full text width.TextWrapping="Wrap",MaxHeight~4 lines,TextTrimmingfor overflow; tooltip still shows the full URL.Verification
dotnet build src/BrowserPicker.UI/BrowserPicker.UI.csproj -p:Version=1.0.0 -p:Platform=x64