Conversation
PR Validation
CSharpierOutputXamlStylerOutputdotnet testOutputRun: PR Validation #24 |
mortenn
force-pushed
the
issue-247-local-url-security
branch
from
7fe26c3 to
3b1ac5f
Compare
Derives picker URL presentation locally for scheme, registrable domain, IDN/punycode, and Windows file path hints without contacting the target host. Adds safer remember-default choices, prevents hostname defaults from matching file URLs, tightens picker row/resize behavior, and adds xUnit/CI coverage for the URL parsing rules. Made-with: Cursor
mortenn
force-pushed
the
issue-247-local-url-security
branch
from
3b1ac5f to
6b5f5bf
Compare
mortenn
commented
Apr 29, 2026
Owner
Author
mortenn
left a comment
mortenn
left a comment
There was a problem hiding this comment.
overall in good shape, but I have some suggestions and questions.
Pins BrowserPicker workflows to the merged shared workflow update, tightens URL hint tooltips, reduces small XAML duplication, and switches the new tests to AwesomeAssertions. Made-with: Cursor
Pins BrowserPicker workflow wrappers to the merged BrowserPicker.Actions fix for PR validation artifact uploads. Made-with: Cursor
Restores the full URL at the top of the picker tooltip, widens wrapping, and separates it visually from the local hint details. Made-with: Cursor
Adds structured URL tooltip lines so the picker can render muted labels next to normal value text while preserving the full URL header. Made-with: Cursor
Renders hint labels inline with muted styling so long values can wrap across the full tooltip width. Made-with: Cursor
Uses inherited tooltip foreground with semibold labels instead of gray text on a gray tooltip background. Made-with: Cursor
Uses the system highlight brush for tooltip labels so they stay distinct in both dark and light tooltip themes. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Fixes #247