Skip to content

Add manual TLS connection check#274

Merged
mortenn merged 2 commits intomainfrom
issue-248-tls-certificate-summary
May 1, 2026
Merged

Add manual TLS connection check#274
mortenn merged 2 commits intomainfrom
issue-248-tls-certificate-summary

Conversation

@mortenn
Copy link
Copy Markdown
Owner

@mortenn mortenn commented May 1, 2026

Summary

  • Adds a user-triggered HTTPS connection check dialog with confirmation, cancellation, TLS certificate details, cipher strength, CAA alignment, and certificate transparency guidance.
  • Adds security settings for certificate record checks, hiding the manual scan action, and skipping the confirmation prompt, including profile and settings persistence updates.
  • Replaces the main picker text action with a padlock indicator that reflects scan results without using traffic-light colors for DNS resolution failures.

Test plan

  • dotnet test tests/BrowserPicker.Common.Tests/BrowserPicker.Common.Tests.csproj

Fixes #248

Made with Cursor

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

PR Validation

Check Result
CSharpier success
XamlStyler success
dotnet test success

CSharpier

Output
Checked 65 files in 958ms.

XamlStyler

Output
Checking: src\BrowserPicker.UI\App.xaml
  PASS
Checking: src\BrowserPicker.UI\Resources\ResourceDictionary.xaml
  PASS
Checking: src\BrowserPicker.UI\Views\BrowserEditor.xaml
  PASS
Checking: src\BrowserPicker.UI\Views\BrowserList.xaml
  PASS
Checking: src\BrowserPicker.UI\Views\Configuration.xaml
  PASS
Checking: src\BrowserPicker.UI\Views\ConnectionCheckWindow.xaml
  PASS
Checking: src\BrowserPicker.UI\Views\ExceptionReport.xaml
  PASS
Checking: src\BrowserPicker.UI\Views\LoadingWindow.xaml
  PASS
Checking: src\BrowserPicker.UI\Views\MainWindow.xaml
  PASS
Checking: src\BrowserPicker.UI\Views\UrlEditor.xaml
  PASS

10 of 10 files pass format check.

dotnet test

Output
  Determining projects to restore...
  Restored D:\a\BrowserPicker\BrowserPicker\dist\Dependent\Dependent.wixproj (in 1.65 sec).
  Restored D:\a\BrowserPicker\BrowserPicker\dist\Portable\Portable.wixproj (in 1.7 sec).
  Restored D:\a\BrowserPicker\BrowserPicker\tests\BrowserPicker.Common.Tests\BrowserPicker.Common.Tests.csproj (in 12.39 sec).
  Restored D:\a\BrowserPicker\BrowserPicker\src\BrowserPicker.Windows\BrowserPicker.Windows.csproj (in 18.56 sec).
  Restored D:\a\BrowserPicker\BrowserPicker\src\BrowserPicker.Common\BrowserPicker.Common.csproj (in 6.17 sec).
  Restored D:\a\BrowserPicker\BrowserPicker\tools\BrowserPicker.SchemaGen\BrowserPicker.SchemaGen.csproj (in 20.22 sec).
  Restored D:\a\BrowserPicker\BrowserPicker\src\BrowserPicker.UI\BrowserPicker.UI.csproj (in 20.31 sec).
  BrowserPicker.Common -> D:\a\BrowserPicker\BrowserPicker\src\BrowserPicker.Common\bin\Debug\net10.0-windows\BrowserPicker.Common.dll
  BrowserPicker.Common.Tests -> D:\a\BrowserPicker\BrowserPicker\tests\BrowserPicker.Common.Tests\bin\x64\Debug\net10.0-windows\BrowserPicker.Common.Tests.dll
Test run for D:\a\BrowserPicker\BrowserPicker\tests\BrowserPicker.Common.Tests\bin\x64\Debug\net10.0-windows\BrowserPicker.Common.Tests.dll (.NETCoreApp,Version=v10.0)
A total of 1 test files matched the specified pattern.
Results File: D:\a\BrowserPicker\BrowserPicker\test-results\dotnet-test.trx

Passed!  - Failed:     0, Passed:    21, Skipped:     0, Total:    21, Duration: 730 ms - BrowserPicker.Common.Tests.dll (net10.0)

Run: PR Validation #26

@mortenn mortenn merged commit e152297 into main May 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security hints: user-triggered TLS and certificate summary

1 participant