Add dark mode / theme system with auto-detection#28
Merged
mortonanalytics merged 1 commit intodevelopfrom Mar 28, 2026
Merged
Conversation
Adds mode-based theming to setTheme(): "light", "dark", and "auto" modes with WCAG AA-verified palettes. Auto mode detects OS preference and Quarto/Bootstrap data-bs-theme via MutationObserver + matchMedia. R: setTheme() gains mode/preset/overrides params (backward compatible) JS: ThemeManager class with palettes, auto-detection, lifecycle cleanup CSS: high-contrast and reduced-motion media queries Tests: 18 R tests, 7 JS vitest tests (25 total) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setTheme(mode = "dark")with WCAG AA-verified dark palette across all chart elementsmode = "auto"— responds to OSprefers-color-schemeand Quarto/Bootstrapdata-bs-themechanges in real-timesetTheme(bg = "#fff")calls still work via nested config normalizationWhat changed
setTheme()gainsmode,preset,overridesparameters. Config structure changed from flat dict to nested{mode, preset, values}with JS-side normalization shim for v1.1.0 saved widgetsThemeManagerclass (theme-manager.js) withnormalizeThemeConfig(),detectEnvironment(), MutationObserver + matchMedia listeners, and lifecycle cleanup. Newpalettes.jswith LIGHT/DARK constants (21 CSS custom properties each)prefers-contrast: more) and reduced-motion (prefers-reduced-motion: reduce) media queriestest_options.R,test_e2e_widgets.R,test_setters_extended.R— migrated from flat dict to nested config assertionsTest plan
devtools::test())npx vitest run, 21 test files)test_theme_mode.R)theme.test.js)data-bs-themetoggle🤖 Generated with Claude Code