RCF-1394 : Added semantics keys for automation

[SachinPremkumar]

RCF-1394

Summary by CodeRabbit

• Improvements

  • Enhanced accessibility across the app: added semantic labels and accessibility wrappers for back/menu buttons, zoom controls, biometric capture tiles, form fields, headers, search and settings inputs—improving screen‑reader clarity while preserving visuals and behavior.

• Localization

  • Added localized strings for "Select Option" and "Cron Expression" and replaced related hard-coded UI and validation text with localized values.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8219e3b and 64b41ad.

📒 Files selected for processing (9)

• assets/l10n/app_ar.arb
• assets/l10n/app_en.arb
• assets/l10n/app_fr.arb
• assets/l10n/app_hi.arb
• assets/l10n/app_kn.arb
• assets/l10n/app_ta.arb
• lib/ui/process_ui/widgets/radio_button_control.dart
• lib/ui/settings/widgets/global_config_settings_tab.dart
• lib/ui/settings/widgets/scheduled_jobs_settings.dart

🚧 Files skipped from review as they are similar to previous changes (7)

• lib/ui/process_ui/widgets/radio_button_control.dart
• assets/l10n/app_hi.arb
• assets/l10n/app_en.arb
• lib/ui/settings/widgets/global_config_settings_tab.dart
• assets/l10n/app_ar.arb
• assets/l10n/app_kn.arb
• assets/l10n/app_ta.arb

---

Walkthrough

Adds Semantics accessibility wrappers and localized strings across multiple UI widgets (back/menu buttons, biometric tiles, zoom controls, form inputs, dropdowns, radio validation, headers, and cron fields). Visual layout, navigation, validation, and business logic are preserved; new localization keys added for select_option and cron_expression.

Changes

Cohort / File(s)	Summary
Back & App Bar Buttons lib/ui/approve_packet/approve_packet_ui.dart, lib/ui/export_packet/export_packet_ui.dart, lib/ui/onboard/widgets/operator_biometric_capture_scan_block_view.dart, lib/ui/process_ui/widgets_mobile/biometric_capture_scan_block_portrait.dart	Wrapped leading/back/menu widgets with Semantics and added accessibility labels (e.g., pending_approval_back_button, manage_application_back_button, menu_back_button); preserved visuals and existing onPressed navigation/handlers.
Biometric Tiles & Zoom Controls lib/ui/onboard/widgets/operator_biometrics_capture_view.dart, lib/ui/process_ui/widgets_mobile/biometric_capture_control_portrait.dart, lib/ui/onboard/widgets/operator_biometric_capture_scan_block_view.dart, lib/ui/process_ui/widgets_mobile/biometric_capture_scan_block_portrait.dart	Wrapped biometric tiles and zoom-in controls with Semantics (labels use biometric titles or zoom_in_button); layout and interactions unchanged. Some views swap back-button asset to assets/images/Menu_Grid.png.
Form Inputs, Headers & Cron Field lib/ui/process_ui/widgets/textbox_control.dart, lib/ui/settings/widgets/global_config_settings_tab.dart, lib/ui/settings/widgets/scheduled_jobs_settings.dart	Added Semantics wrappers with explicit labels around TextFormField/TextField and header texts; cron input labeled ${job.id}_cron_expression. Minor padding/font-size/hint text adjustments; validation and persistence logic unchanged.
Dropdowns & Radio Validation Localization lib/ui/process_ui/widgets/dropdown_control.dart, lib/ui/process_ui/widgets/dynamic_dropdown_control.dart, lib/ui/process_ui/widgets/radio_button_control.dart	Replaced hard-coded "Select Option" with AppLocalizations.of(context)!.select_option for hints and validation messages; moved hint into InputDecoration where applicable.
Localization Files assets/l10n/app_en.arb, assets/l10n/app_ar.arb, assets/l10n/app_fr.arb, assets/l10n/app_hi.arb, assets/l10n/app_kn.arb, assets/l10n/app_ta.arb	Added select_option and cron_expression localization keys and adjusted JSON formatting (trailing commas) to include the new entries.
Misc / Manifest Reference pubspec.yaml	Manifest referenced in diff metadata; no API signature changes detected.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped through code with gentle paws,
Pasted tiny labels, fixed no flaws,
Gave buttons voices, fields a name,
Now screens can speak — the same UI, humane,
A carrot-coded cheer for access and aims. 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding semantic keys for automation across multiple UI files for accessibility and testing purposes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (2)

lib/ui/settings/widgets/global_config_settings_tab.dart (1)

281-295: Consider adding textField: true for better accessibility while maintaining automation support.

The excludeSemantics: true configuration strips accessibility information from screen readers. While this pattern is used throughout the codebase for Appium test automation, you can improve accessibility by explicitly marking the field as a text input.

Note that other text fields in this file use excludeSemantics: false with textField: true (e.g., the editable config fields). Consider applying the same approach here for consistency.

Suggested change

-            excludeSemantics: true,
+            textField: true,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/ui/settings/widgets/global_config_settings_tab.dart` around lines 281 -
295, Update the Semantics widget wrapping the search TextField (label
'global_config_search') to include textField: true and make it expose semantics
(set excludeSemantics: false) so the field is announced as a text input by
screen readers; modify the Semantics constructor around the TextField in
global_config_settings_tab.dart accordingly to match the other editable config
fields.

lib/ui/export_packet/export_packet_ui.dart (1)

29-51: LGTM – back button Semantics label correctly applied.

One optional consistency note: the biometric file uses container: true on its Semantics nodes, while this one omits it. Functionally the label is still reachable by Appium either way, but aligning the pattern would keep the codebase uniform.

🔧 Optional – add `container: true` for consistency

 leading: Semantics(
   label: "manage_application_back_button",
+  container: true,
   excludeSemantics: true,
   child: Container(

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/ui/export_packet/export_packet_ui.dart` around lines 29 - 51, Add
container: true to the Semantics widget that wraps the back button (the
Semantics with label "manage_application_back_button") to match the biometric
file pattern; locate the Semantics instance in export_packet_ui.dart that wraps
the leading back button and add the container: true property so the widget tree
is consistent while keeping the existing label and children unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/ui/process_ui/widgets_mobile/biometric_capture_scan_block_portrait.dart`:
- Around line 1944-1959: The Left Hand branch in _returnExceptionImage() is
missing the Semantics wrapper used on the Right Hand zoom icon, causing Appium
selectors for "zoom_in_button" to fail; wrap the Left Hand zoom Icon's Container
in a Semantics widget with label "zoom_in_button", container: true, and
excludeSemantics: true (matching the Right Hand branch) so both branches expose
the same accessibility node.

In `@lib/ui/process_ui/widgets/textbox_control.dart`:
- Around line 170-176: The Semantics label used in the choosenLang.map() loop is
non-unique across languages; update the Semantics wrapping the TextFormField (in
the choosenLang.map() block) to append the current lang value to the label
(e.g., combine widget.e.id and lang) so each language variant has a unique
semantic label for testing and accessibility.

---

Nitpick comments:
In `@lib/ui/export_packet/export_packet_ui.dart`:
- Around line 29-51: Add container: true to the Semantics widget that wraps the
back button (the Semantics with label "manage_application_back_button") to match
the biometric file pattern; locate the Semantics instance in
export_packet_ui.dart that wraps the leading back button and add the container:
true property so the widget tree is consistent while keeping the existing label
and children unchanged.

In `@lib/ui/settings/widgets/global_config_settings_tab.dart`:
- Around line 281-295: Update the Semantics widget wrapping the search TextField
(label 'global_config_search') to include textField: true and make it expose
semantics (set excludeSemantics: false) so the field is announced as a text
input by screen readers; modify the Semantics constructor around the TextField
in global_config_settings_tab.dart accordingly to match the other editable
config fields.

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

lib/ui/process_ui/widgets/radio_button_control.dart (1)

158-164: ⚠️ Potential issue | 🔴 Critical

Remove const from Text constructor—non-const interpolated string breaks compilation.

AppLocalizations.of(context)!.select_option is a runtime expression, so the interpolated string "* ${...}" is not compile-time constant. Dart requires all arguments to a const constructor to be compile-time constants, making this a build failure. Keep const on TextStyle since its arguments are all compile-time constants.

Fix

  showError
-     ? const Text(
-         "* ${AppLocalizations.of(context)!.select_option}",
-         style: TextStyle(
-             color: Color.fromARGB(255, 159, 21, 11),
-             fontSize: 12),
-       )
+     ? Text(
+         "* ${AppLocalizations.of(context)!.select_option}",
+         style: const TextStyle(
+             color: Color.fromARGB(255, 159, 21, 11),
+             fontSize: 12),
+       )
      : const SizedBox.shrink(),

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/ui/process_ui/widgets/radio_button_control.dart` around lines 158 - 164,
The Text widget uses a runtime-interpolated string "*
${AppLocalizations.of(context)!.select_option}" but is marked const, causing a
compile error; remove the const from the Text constructor while keeping the
inner TextStyle as const so change the widget at the showError branch to use
Text(...) (non-const) with the existing const TextStyle(...) intact, referencing
the same Text, AppLocalizations.of(context), and TextStyle symbols.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/ui/onboard/widgets/operator_biometric_capture_scan_block_view.dart`:
- Around line 2381-2383: The Image.asset call using
"assets/images/Menu_Grid.png" in operator_biometric_capture_scan_block_view.dart
is not declared in pubspec.yaml; open pubspec.yaml and add
"assets/images/Menu_Grid.png" (or the containing folder like "assets/images/")
under the flutter: assets: section so Flutter bundles the image at runtime; save
and run flutter pub get to ensure the asset is registered.

---

Outside diff comments:
In `@lib/ui/process_ui/widgets/radio_button_control.dart`:
- Around line 158-164: The Text widget uses a runtime-interpolated string "*
${AppLocalizations.of(context)!.select_option}" but is marked const, causing a
compile error; remove the const from the Text constructor while keeping the
inner TextStyle as const so change the widget at the showError branch to use
Text(...) (non-const) with the existing const TextStyle(...) intact, referencing
the same Text, AppLocalizations.of(context), and TextStyle symbols.

---

ℹ️ Review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 12f6342 and 55e80d3.

⛔ Files ignored due to path filters (1)

• assets/images/Menu_Grid.png is excluded by !**/*.png

📒 Files selected for processing (12)

• assets/l10n/app_ar.arb
• assets/l10n/app_en.arb
• assets/l10n/app_fr.arb
• assets/l10n/app_hi.arb
• assets/l10n/app_kn.arb
• assets/l10n/app_ta.arb
• lib/ui/onboard/widgets/operator_biometric_capture_scan_block_view.dart
• lib/ui/process_ui/widgets/dropdown_control.dart
• lib/ui/process_ui/widgets/dynamic_dropdown_control.dart
• lib/ui/process_ui/widgets/radio_button_control.dart
• lib/ui/process_ui/widgets_mobile/biometric_capture_scan_block_portrait.dart
• lib/ui/settings/widgets/scheduled_jobs_settings.dart

🚧 Files skipped from review as they are similar to previous changes (2)

• lib/ui/process_ui/widgets_mobile/biometric_capture_scan_block_portrait.dart
• lib/ui/process_ui/widgets/dropdown_control.dart