Skip to content

pin Helm version#921

Merged
spacewander merged 1 commit into
mosn:mainfrom
tznbdbb:main-2
Sep 1, 2025
Merged

pin Helm version#921
spacewander merged 1 commit into
mosn:mainfrom
tznbdbb:main-2

Conversation

@tznbdbb
Copy link
Copy Markdown
Contributor

@tznbdbb tznbdbb commented Sep 1, 2025

Background

While running e2e tests with the latest Helm (Version: v3.18.6, GitCommit: b76a950f6835474e0906b96c9ec68a2eff3a6430), I observed unexpected schema validation error:

Error: INSTALLATION FAILED: values don't meet the specifications of the schema(s) in the following chart(s):

I used an older Helm version to address this issue.

Changes

  • Pinned HELM_VERSION to v3.17.1, a known working version.

@github-actions github-actions Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 1, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.46%. Comparing base (528d3ad) to head (6044cb3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
- Coverage   85.56%   85.46%   -0.11%     
==========================================
  Files         141      141              
  Lines        8557     8557              
==========================================
- Hits         7322     7313       -9     
- Misses        968      974       +6     
- Partials      267      270       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tznbdbb tznbdbb changed the title pin Helm version and add helm lint before helm install pin Helm version Sep 1, 2025
Comment thread e2e/Makefile
KUBECTL ?= $(LOCALBIN)/kubectl
KIND ?= $(LOCALBIN)/kind
HELM ?= $(LOCALBIN)/helm
HELM_VERSION ?= v3.17.1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment about why we need to pin the version?

@spacewander spacewander merged commit 34ad2fb into mosn:main Sep 1, 2025
16 checks passed
@tznbdbb tznbdbb deleted the main-2 branch November 1, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants