Skip to content

sdk-v3: Add a comment about retry #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeviaVir merged 1 commit into from
Oct 21, 2024
Merged

sdk-v3: Add a comment about retry #758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,14 @@ const CloudWatchLogs = require(path.join(__dirname, 'cloudwatch_logs'))
const AWSXRay = require('aws-xray-sdk-core')
const { createNamespace } = require('continuation-local-storage')

// Migrating to v3.
/*
* Migrating to v3.
*
* # About retry
* By default, each client already has a default retry strategy.
* The default retry count is 3, and only retryable errors will be retried.
* https://docs.aws.amazon.com/sdkref/latest/guide/feature-retry-behavior.html
*/
const { LambdaClient, CreateFunctionCommand } = require('@aws-sdk/client-lambda')
const lambdaClient = new LambdaClient()

Expand Down Expand Up @@ -693,7 +700,6 @@ Emulate only the body of the API Gateway event.

_uploadNew (lambda, params) {
if (process.env.USE_AWS_SDK_V3) {
// todo retry
console.log('DEBUG: Use AWS SDK V3: CreateFunctionCommand()')
const command = new CreateFunctionCommand(params)
return lambdaClient.send(command)
Expand Down