Add option to wrap compiled code in get() method
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also sorry I squashed your original commits into this pull request... I got a little lost in how to modify your PR before merging 😅 |
|
@timhaywood sweet, thanks for taking a look! Yeah, that makes sense to limit the scope—I'm aligned. And no worries, I know how git can be, haha! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fartinmartin I made a few slight changes, mainly removing the typescript based formatting.
I think formatting is probably better handled in the rollup config file of users of this, so they can decide if/how they want to format the output, minify it, obfuscate it etc. Makes sense to limit the scope of this package to compiling to a
jsxcompatible output in my opinion.Let me know what you think! Appreciate your work on this.