fix: update useMotionRef to properly handle externalRef changes#3366
Merged
mattgperry merged 3 commits intoSep 16, 2025
Merged
Conversation
- Add externalRef to useCallback dependency array - Fixes issue where motion components don't update refs when externalRef changes - Add test case to verify ref swapping works correctly - Resolves motiondivision#3361
…ivision#3361 & Test verifies that refs are properly cleared and updated when externalRef changes
…te refs when externalRef changes. The function now properly includes in the dependency array to ensure ref callbacks update when the external ref changes. ## [12.23.12] 2025-07-29
Collaborator
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where motion components don't update refs when externalRef changes.
Root Cause
The
useMotionReffunction wasn't includingexternalRefin theuseCallbackdependency array, causing the ref callback to not update when the external ref changes.Changes
externalRefto the dependency array inuseMotionRefTesting
Files Changed
packages/framer-motion/src/motion/utils/use-motion-ref.tspackages/framer-motion/src/motion/__tests__/ref-change.test.tsxCHANGELOG.mdFixes #3361