PHP version upgrade to 7.4 and PHPUnit upgrade to ^9.0.#29
Merged
mougrim merged 3 commits intomougrim:masterfrom Feb 5, 2022
Merged
PHP version upgrade to 7.4 and PHPUnit upgrade to ^9.0.#29mougrim merged 3 commits intomougrim:masterfrom
mougrim merged 3 commits intomougrim:masterfrom
Conversation
Owner
|
Hi! As I see php7.4 is supported yet. For libxml_disable_entity_loader you can use suggest form your link: - libxml_disable_entity_loader(true);
+ if (\PHP_VERSION_ID < 80000) {
+ libxml_disable_entity_loader(true);
+ }Please, fix it. Also, could you fix .travis.yml? Need to remove old php version and add 7.4, 8.0, 8.1 (if supported by travis). |
Owner
|
Sorry, looks like travis doesn't work now, so, isn't need to change .travis.yml. |
Contributor
Author
|
Thanks for your fast reply! Changes done. |
Owner
|
Thanks! php8.1 and php8.0 are ok. Looks like need to update composer.lock. Also, could you update CHANGELOG.md? |
Owner
|
Thanks! Will add composer.lock later with code-style fixes (after update cs tool). |
This was referenced Feb 5, 2022
Merged
mougrim
added a commit
that referenced
this pull request
Feb 5, 2022
There are next changes: - Minimum PHP version supported upgraded to 7.4 (#29) - PHPUnit version upgraded to 9 (#29) - Add run unit tests Github action (#30, #31) - Remove travis (#30) - Fix code style issues (#32) - Fix by workaround grumphp issue with TypeError, see phpro/grumphp#957 (#32) - Update friendsofphp/php-cs-fixer to 3 (#33) - Add psalm (#34, #35) - Add check cs github action (#36)
mougrim
added a commit
that referenced
this pull request
Feb 5, 2022
There are next changes: - Minimum PHP version supported upgraded to 7.4 (#29) - PHPUnit version upgraded to 9 (#29) - Add run unit tests Github action (#30, #31) - Remove travis (#30) - Fix code style issues (#32) - Fix by workaround grumphp issue with TypeError, see phpro/grumphp#957 (#32) - Update friendsofphp/php-cs-fixer to 3 (#33) - Add psalm (#34, #35) - Add check cs github action (#36)
Owner
|
@ales-k, released v0.5.0 |
Contributor
Author
|
Thank you very much for your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8 disables libxml_disable_entity_loader by default:
https://php.watch/versions/8.0/libxml_disable_entity_loader-deprecation
PHPUnit - changing method expectExceptionMessageRegExp() to expectExceptionMessageMatches():
sebastianbergmann/phpunit#4133
I actually tested executing in PHP 8.0 and it worked. I also executed phpunit tests which (after my changes) passed. However I am new to contributing so I will be really glad for any feedback or advice how to make sure that my changes are correct and actually helpful.