Skip to content

feat: add SilentClose(io.Closer)#2

Merged
moul merged 2 commits intomasterfrom
dev/moul/silentclose
Aug 3, 2020
Merged

feat: add SilentClose(io.Closer)#2
moul merged 2 commits intomasterfrom
dev/moul/silentclose

Conversation

@moul
Copy link
Owner

@moul moul commented Aug 3, 2020

f, _ := os.Open("file.txt")
defer u.SilentClose(f) 

@auto-add-label auto-add-label bot added the enhancement New feature or request label Aug 3, 2020
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Aug 3, 2020
@moul-bot moul-bot force-pushed the dev/moul/silentclose branch from 8152af6 to d8d2bbe Compare August 3, 2020 15:23
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul-bot moul-bot force-pushed the dev/moul/silentclose branch from d8d2bbe to 4b36fc8 Compare August 3, 2020 15:23
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@08579e0). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master        #2   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?         2           
  Lines             ?         9           
  Branches          ?         0           
==========================================
  Hits              ?         9           
  Misses            ?         0           
  Partials          ?         0           
Flag Coverage Δ
#unittests 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
io.go 100.00% <100.00%> (ø)
crypto.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08579e0...6f5e90a. Read the comment docs.

@moul moul self-assigned this Aug 3, 2020
@github-actions
Copy link

github-actions bot commented Aug 3, 2020

Expected release notes (by @moul-bot)

features:
add SilentClose(io.Closer) (4b36fc8)

fixes:
add missing unit tests (6f5e90a)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@moul moul merged commit 5e796bf into master Aug 3, 2020
@moul moul deleted the dev/moul/silentclose branch August 3, 2020 15:28
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Aug 3, 2020
@github-actions
Copy link

github-actions bot commented Aug 3, 2020

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ✨ Merged Pull Request has been merged successfully released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant