Skip to content

feat: add workdir argument#3

Merged
tuoxiansp merged 2 commits intomouldjs:masterfrom
rostislavbobo:workdir
Sep 14, 2020
Merged

feat: add workdir argument#3
tuoxiansp merged 2 commits intomouldjs:masterfrom
rostislavbobo:workdir

Conversation

@rostislavbobo
Copy link
Copy Markdown
Collaborator

@rostislavbobo rostislavbobo commented Sep 14, 2020

Add an optional workdir CLI argument to specify the Mould root directory

workdir

Copy link
Copy Markdown
Contributor

@tuoxiansp tuoxiansp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

'node',
['-r', 'esm', require.resolve(`./commands/${command}`)],
{ stdio: 'inherit' }
{ env: { ...process.env, WORKDIR: workdir }, stdio: 'inherit' }
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could've overridden cwd, but the original cwd is used to check for tsconfig.json and yarn.lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants