Add configurable hotkey for editor autocomplete trigger #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the hardcoded Ctrl-Space autocomplete trigger in CodeMirror with the existing configurable hotkey system. This adds a new 'editor.autocomplete' hotkey action that defaults to Control+Space on all platforms. Changes: - Add 'editor.autocomplete' to HotkeyAction type with default Control+Space - Filter out the built-in completion trigger from CodeMirror's completionKeymap - Add custom keydown handler in Editor that triggers startCompletion() - Export eventMatchesHotkey() helper for checking hotkey matches - Add 'Space' to layout-insensitive keys for proper spacebar detection 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add 'Space' to LAYOUT_INSENSITIVE_KEYS so that the spacebar is recorded as 'Space' (using e.code) instead of ' ' (using e.key), matching the format used in useHotKey.ts for hotkey matching. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
editor.autocompletehotkey action that defaults toControl+Spaceon all platforms