Fix HTTP/2 requests failing with duplicate Content-Length #391
+91
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Yaak moved compression, redirect, and multipart handling out of reqwest, it started explicitly adding Content-Length as an HTTP header. Over HTTP/2, hyper also sets content-length internally via DATA frame sizing, causing a duplicate that HTTP/2 servers (like Node.js) reject with PROTOCOL_ERROR. Instead of setting Content-Length as an explicit header, carry the content length through SendableBody::Stream and use http_body::Body's size_hint() to let hyper handle it automatically for both HTTP/1.1 and HTTP/2. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes HTTP/2 request failures caused by sending duplicate Content-Length headers, by stopping build_body from explicitly adding Content-Length and instead propagating known stream lengths so the HTTP client stack (hyper/reqwest) can set Content-Length appropriately.
Changes:
- Refactored
SendableBody::Streamto carry an optionalcontent_lengthalongside the stream data. - Removed explicit
Content-Lengthheader injection inbuild_body, updating tests accordingly. - Added a
SizedBodywrapper intended to exposesize_hint()for streamed bodies with known length.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/yaak-http/src/types.rs | Carries stream content length via SendableBody and removes explicit Content-Length header insertion logic/tests. |
| crates/yaak-http/src/sender.rs | Attempts to pass content-length to hyper via a custom http_body::Body wrapper for streamed requests. |
| crates/yaak-http/Cargo.toml | Adds http-body dependency to implement the custom body wrapper. |
| crates-tauri/yaak-app/src/http_request.rs | Updates pattern matching / reconstruction of SendableBody::Stream to preserve content_length. |
| Cargo.lock | Records the new http-body dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Wrap inner stream in std::sync::Mutex instead of unsafe impl Sync - Use poll_next_unpin instead of Pin::new + poll_next - Fix doc comment about Content-Length not being an HTTP/2 pseudo-header Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zouyq
pushed a commit
to zyqfork/yaak
that referenced
this pull request
Feb 12, 2026
…oop#391) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROTOCOL_ERRORwhen connecting to HTTP/2-only servers (e.g., Vite dev server with HTTPS)Content-Lengthas an HTTP header, but hyper also sets it internally for HTTP/2 DATA frames, causing a duplicate that HTTP/2 servers rejectContent-Lengthas an explicit header, the content length is now carried throughSendableBody::Stream { content_length }and reported viahttp_body::Body::size_hint(), letting hyper handle it correctly for both HTTP/1.1 and HTTP/2