Add support for client assertions in the OAuth 2 plugin#395
Merged
gschier merged 4 commits intomountain-loop:mainfrom Feb 14, 2026
Merged
Add support for client assertions in the OAuth 2 plugin#395gschier merged 4 commits intomountain-loop:mainfrom
gschier merged 4 commits intomountain-loop:mainfrom
Conversation
gschier
approved these changes
Feb 14, 2026
Member
gschier
left a comment
There was a problem hiding this comment.
Amazing! Thanks for doing this. I'm okay with the untested code. I did some research with Claude and it seems to be correct 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for client assertions in the OAuth 2 plugin. As an alternative to sending a static
client_secret, this allows to send aclient_assertionthat is a signed JWT.Full disclaimer: I've only tried this with a single algorithm + secret + auth provider combination, since that's the only one I currently have access to. After I had a working version with my testcase I asked Claude Opus 4.6 to add functionality that matches the RFC spec. This mostly added support for other secret types (HMAC & PEM):
However, this part is untested. I also don't have an OAuth provider with basic client_id / client_secret combination at hand right now. I was careful to keep the existing functionality the same, I would appreciate someone testing this first to be sure.
I also noticed when running
npm run formatthat it changed a few lines I did not touch.Closes https://yaak.app/feedback/posts/support-for-oauth-2-client-assertions-jwks