Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
StartLogCleanupbehavior is covered for file output, ensuring expired archived logs are removed, recent/today files are preserved, and the cleanup goroutine stops on context cancellation.Description
fastdeploy/golang_router/pkg/logger/logger_test.goto exerciseStartLogCleanupwith a controllednowFunc, temporary log directory, and context cancellation.rotatingWriterthat simulates a cross-day transition and verifies that late previous-day lines are written to the previous-day file and thatrouter.logsymlink points to the new day file.waitForConditionhelper and adjusted imports to support time control and temporary directories used by the tests.Testing
cd fastdeploy/golang_router && go test ./pkg/loggerand the package tests passed (ok).TestStartLogCleanupandTestRotatingWriterCrossDayGracePeriodIntegrationas part of the package test run and succeeded.Codex Task