Skip to content
This repository was archived by the owner on May 4, 2024. It is now read-only.

Conversation

@yubing744
Copy link
Contributor

Motivation

The previous default value configuration, even if I configure the PATH, it will prompt that the executable program cannot be found here.

Have you read the Contributing Guidelines on pull requests?

YES

Test Plan

I manually tested three scenarios:

  1. If move-analyzer is not installed, an error will be prompted
  2. Through cargo install, the plugin can be loaded normally
  3. Configure the move-analyzer path through the plug-in, and the plug-in can be loaded normally

@yubing744 yubing744 changed the title feat: ok for serverPath check [move-analyzer] Fix bug for move-analyzer not found Jun 27, 2022
@jolestar jolestar requested a review from awelc June 27, 2022 01:50
Copy link
Collaborator

@awelc awelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@awelc awelc merged commit f5e22e8 into move-language:main Jun 27, 2022
villesundell pushed a commit to villesundell/move that referenced this pull request Jul 7, 2022
nkysg pushed a commit to starcoinorg/move that referenced this pull request Sep 27, 2022
brson added a commit to brson/move that referenced this pull request Jul 11, 2023
brson added a commit to brson/move that referenced this pull request Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants