show only error logs as error#5
Merged
Merged
Conversation
psenderos
reviewed
Apr 9, 2026
| if strings.Contains(msg, "error") || strings.Contains(msg, "failed") || strings.Contains(msg, "fatal") { | ||
| logrus.Error(msg) | ||
| } else { | ||
| logrus.Debug(msg) |
Member
There was a problem hiding this comment.
Hi @patostickar would this appear even without the --debug flag, or would it be better to log it as Info?
Also, shouldn't the string be lowercase so it also catches "ERROR" or "Error"?
Collaborator
Author
There was a problem hiding this comment.
@psenderos, if errors are real errors, they will appear without the need for the debug flag to be enabled.
There I lowercased the msg 💪
psenderos
approved these changes
Apr 17, 2026
gdecicco
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop showing debug logs as errors and only show error logs if they are truly error ones