Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port moveit_msgs actions #28

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Port moveit_msgs actions #28

merged 1 commit into from
Feb 26, 2019

Conversation

davetcoleman
Copy link
Member

I believe this is the correct approach to actions, and I tried to document it: ros2/ros2_documentation#130

@davetcoleman davetcoleman mentioned this pull request Feb 24, 2019
Merged
@vmayoral
Copy link
Contributor

@vmayoral approves this PR https://travis-ci.org/AcutronicRobotics/moveit2/builds/498338100

@davetcoleman
Copy link
Member Author

i need an actual "approval" button click, do you have access to this @vmayoral ?

Merging can be performed automatically with 1 approving review.

@mlautman

@davetcoleman davetcoleman merged commit e753123 into moveit:master Feb 26, 2019
@davetcoleman davetcoleman deleted the adapt_moveit_actions branch February 26, 2019 19:19
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
@mlautman @davetcoleman
adding information about the new parameterization algorithm (moveit#28)
6c597a5
@madgrizzle madgrizzle mentioned this pull request Nov 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlautman mlautman mlautman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davetcoleman @vmayoral @mlautman