Skip to content

Add Kinetic to dropdown list#205

Closed
MadsRossen wants to merge 1 commit intomoveit:foxyfrom
MadsRossen:patch-1
Closed

Add Kinetic to dropdown list#205
MadsRossen wants to merge 1 commit intomoveit:foxyfrom
MadsRossen:patch-1

Conversation

@MadsRossen
Copy link
Copy Markdown

Added the Kinetic to the dropdownlist for Foxy tutorial

Description

Please explain the changes you made, including a reference to the related issue if applicable

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

Added the Kinetic to the dropdownlist for Foxy tutorial
@MadsRossen MadsRossen changed the title Add Kinetic to downlist Add Kinetic to dropdown list Nov 11, 2021
@vatanaksoytezer
Copy link
Copy Markdown
Contributor

Thanks for the PR @MadsRossen. Since Kinetic has been EOL for a long time we recently removed it from down list since it's not maintained anymore: #179. I don't think we should add them back.

@MadsRossen
Copy link
Copy Markdown
Author

@vatanaksoytezer
Copy link
Copy Markdown
Contributor

Is there a reason why they are not removed from the other tutorials?

PRs are up (moveit/moveit_tutorials#675 and moveit/moveit_tutorials#676) but not merged, I'll test and approve them, and hopefully get them merged soon 👍🏻. In the meantime I'm closing this PR since we won't want to add them back. Feel free to re-open it or ask any questions you might have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants