Add Kinetic to dropdown list#205
Closed
MadsRossen wants to merge 1 commit intomoveit:foxyfrom
Closed
Conversation
Added the Kinetic to the dropdownlist for Foxy tutorial
Contributor
|
Thanks for the PR @MadsRossen. Since Kinetic has been EOL for a long time we recently removed it from down list since it's not maintained anymore: #179. I don't think we should add them back. |
Author
|
Is there a reason why they are not removed from the other tutorials? and Otherwise thanks for the quick response @vatanaksoytezer 😊 |
Contributor
PRs are up (moveit/moveit_tutorials#675 and moveit/moveit_tutorials#676) but not merged, I'll test and approve them, and hopefully get them merged soon 👍🏻. In the meantime I'm closing this PR since we won't want to add them back. Feel free to re-open it or ask any questions you might have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the Kinetic to the dropdownlist for Foxy tutorial
Description
Please explain the changes you made, including a reference to the related issue if applicable
Checklist