Skip to content

Conversation

@tylerjw
Copy link
Member

@tylerjw tylerjw commented Oct 3, 2020

Description

This makes the move_group_python_interface_tutorial both python2 and python3 compatible. This is needed to run this tutorial on Noetic.

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this. There are other not yet python3 compliant python files though. Please handle them all:
doc/collision_environments/scripts/collision_scene_example.py
_scripts/tutorialformatter.py

@tylerjw tylerjw force-pushed the p/move_group_python3 branch from d1a9090 to 42d68a0 Compare October 4, 2020 18:48
@tylerjw tylerjw changed the title Python3 migration of move_group_python_interface_tutorial Python3 migration Oct 4, 2020
@tylerjw
Copy link
Member Author

tylerjw commented Oct 4, 2020

Thanks for starting this. There are other not yet python3 compliant python files though. Please handle them all:
doc/collision_environments/scripts/collision_scene_example.py
_scripts/tutorialformatter.py

@rhaschke I updated this to include changes for collision_scene_example.py but was not able to find anything wrong with tutorialformatter.py. I also don't understand how tutorialformatter.py is used so I wasn't able to test it outside of just calling it with python3 (which runs without error and produces no output).

@rhaschke
Copy link
Contributor

rhaschke commented Oct 6, 2020

I was not able to find anything wrong with tutorialformatter.py.

Sorry for the noise. I was looking at an older version of the file. Michael already fixed some stuff a while ago (#410).

I also don't understand how tutorialformatter.py is used so I wasn't able to test it outside of just calling it with python3

It's used as a plugin to sphinx, generating the docs:
https://github.com/ros-planning/moveit_tutorials/blob/f0ac33f91603d7bffa8592d9a9b4943cec7eedea/conf.py#L5-L6

@rhaschke rhaschke merged commit 04cd003 into moveit:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants