Skip to content

Conversation

@henningkayser
Copy link
Member

Fixes the html error reported in #779.
<embed> is an empty element and must not have an end tag (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/embed#technical_summary)

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this.

@rhaschke rhaschke merged commit f9239e9 into master May 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the pr/fix_html branch May 22, 2023 10:56
@henningkayser
Copy link
Member Author

@rhaschke I don't think that you are supposed to add / for closing void tags, self-closing tags don't even exist in HTML. Do we have any need to support xhtml?

@rhaschke
Copy link
Contributor

Thanks for the read. I was expecting HTML to be a subset of XML. For me, not having the self-closing tag, reads strange.
Obviously, both are OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants