SDK upgrade #111
Closed
SDK upgrade #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstenner
force-pushed
the
sdkupdate
branch
2 times, most recently
from
6b66841 to
c923de5
Compare
Member
|
Whoa! This is a massive PR in a positive way. I'll try to allocate some time this week for review and build it locally. Thanks! |
Author
|
FIY, I rebased the PR against the current master |
hitman99
reviewed
Sep 5, 2023
Member
There was a problem hiding this comment.
Why was the entire deploy directory removed? CRDs and role are moved to other location - that's fine, but there was so much more manifests in this directory.
Author
There was a problem hiding this comment.
We're deploying the helm chart internally, but I added the default configuration from the SDK skeleton with some defaults I would expect from the readme / previous defaults.
tstenner
force-pushed
the
sdkupdate
branch
2 times, most recently
from
e843503 to
a44b73e
Compare
Add configurable prefix for DB names
tstenner
force-pushed
the
sdkupdate
branch
2 times, most recently
from
45f9337 to
95d57d4
Compare
Author
|
I rebased the branch against the latest master. |
Contributor
|
Closed, a lot was reused in #172 , thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have ported the code from the current master to a clean project created with the current kubebuilder (targeting the controller-runtime 0.15 and kubernetes 1.27).
This is basically #100, but with tests passing against
export ENVTEST_K8S_VERSION=1.26.x; . <(bin/setup-envtest use -p env $ENVTEST_K8S_VERSION); ginkgo run --flake-attempts=2 internal/controller/The second commit also addresse #110