Add PVDO table and PVTTableSet return type to PVTExperiments#28
Merged
Conversation
Co-authored-by: moyner <454871+moyner@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add PVDO output to PVT tables generation
Add PVDO table and PVTTableSet return type to PVTExperiments
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate_pvt_tablesalways generated PVDG but had no equivalent dead oil (PVDO) table, and returned an anonymousNamedTuplemaking downstream type dispatch impossible.Changes
PVDOTablestruct — mirrorsPVDGTablewithp,Bo,mu_ofieldsPVTTableSetstruct — typed container replacing theNamedTuplereturn; exported so downstream packages can dispatch on itpvdo_tablefunction — always generated like PVDG; uses overall composition for oil systems, liquid composition near dew point for gas systemsgenerate_pvt_tablesupdates — addsn_pvdokwarg (default: 20), generates PVDO, returnsPVTTableSetBase.showmethods forPVDOTableandPVTTableSetUsage
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/FluxML/MacroTools.jl/tarball/1e0228a030642014fe5cfe68c2c0a818f9e3f522/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaArrays/StaticArrays.jl/tarball/246a8bb2e6667f832eea063c3a56aef96429a3db/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaArrays/StaticArraysCore.jl/tarball/6ab403037779dae8c514bad259f32a447262455a/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaBinaryWrappers/OpenSpecFun_jll.jl/tarball/1346c9208249809840c91b26703912dff463d335/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaDiff/DiffResults.jl/tarball/782dd5f4561f5d267313f23853baaaa4c52ea621/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaDiff/DiffRules.jl/tarball/23163d55f885173722d1e4cf0f6110cdbaf7e272/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaDiff/ForwardDiff.jl/tarball/eef4c86803f47dcb61e9b8790ecaa96956fdd8ae/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaDocs/DocStringExtensions.jl/tarball/7442a5dfe1ebb773c29cc2962a8980f47221d76c/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaFunctional/CompositionsBase.jl/tarball/802bb88cd69dfd1509f6670416bd4434015693ad/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaLang/PrecompileTools.jl/tarball/07a921781cab75691315adc645096ed5e370cb77/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaMath/InverseFunctions.jl/tarball/a779299d77cd080bf77b97535acecd73e1c5e5cb/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaMath/IrrationalConstants.jl/tarball/b2d91fe939cae05960e760110b328288867b5758/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaMath/NaNMath.jl/tarball/9b8215b1ee9e78a293f99797cd31375471b2bcae/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaMath/Roots.jl/tarball/10a488dbecb88a9679c8f357d383d7d83dcc748d/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaMath/SpecialFunctions.jl/tarball/5acc6a41b3082920f79ca3c759acbcecf18a8d78/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaObjects/Accessors.jl/tarball/856ecd7cebb68e5fc87abecd2326ad59f0f911f3/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaObjects/ConstructionBase.jl/tarball/b4b092499347b18a015186eae3042f72267106cb/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaPackaging/JLLWrappers.jl/tarball/0533e564aae234aff59ab625543145446d8b6ec2/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaPackaging/Preferences.jl/tarball/8b770b60760d4451834fe79dd483e318eee709c4/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/JuliaStats/LogExpFunctions.jl/tarball/13ca9e2586b89836fd20cccf56e57e2b9ae7f38f/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/SciML/CommonSolve.jl/tarball/78ea4ddbcf9c241827e7035c3a03e2e456711470/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)https://api.github.com/repos/rdeits/CommonSubexpressions.jl/tarball/cda2cfaebb4be89c9084adaca7dd7333369715c5/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(http block)pkg.julialang.org/usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate()(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.