Skip to content

Conversation

@besaleli
Copy link
Member

No description provided.

@besaleli besaleli added the enhancement New feature or request label Dec 10, 2025
@besaleli besaleli linked an issue Dec 10, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 68.32061% with 83 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
encoderfile-core/src/cli.rs 0.00% 20 Missing ⚠️
encoderfile-core/src/server.rs 0.00% 16 Missing ⚠️
encoderfile-core/src/common/embedding.rs 0.00% 6 Missing ⚠️
encoderfile-core/src/common/sentence_embedding.rs 0.00% 6 Missing ⚠️
...derfile-core/src/common/sequence_classification.rs 0.00% 6 Missing ⚠️
...ncoderfile-core/src/common/token_classification.rs 0.00% 6 Missing ⚠️
encoderfile-core/src/factory.rs 0.00% 6 Missing ⚠️
encoderfile-core/src/runtime/state.rs 78.57% 6 Missing ⚠️
encoderfile-core/src/transport/grpc/mod.rs 25.00% 6 Missing ⚠️
encoderfile/src/model.rs 57.14% 3 Missing ⚠️
... and 2 more
Files with missing lines Coverage Δ
encoderfile-core/src/common/model_type.rs 100.00% <100.00%> (ø)
encoderfile-core/src/dev_utils/mod.rs 100.00% <100.00%> (ø)
encoderfile-core/src/inference/embedding.rs 100.00% <100.00%> (ø)
...coderfile-core/src/inference/sentence_embedding.rs 100.00% <100.00%> (ø)
...file-core/src/inference/sequence_classification.rs 100.00% <100.00%> (ø)
...derfile-core/src/inference/token_classification.rs 96.61% <100.00%> (+0.05%) ⬆️
encoderfile-core/src/services/embedding.rs 100.00% <100.00%> (ø)
encoderfile-core/src/services/model_metadata.rs 100.00% <100.00%> (ø)
...ncoderfile-core/src/services/sentence_embedding.rs 100.00% <100.00%> (ø)
...ncoderfile-core/src/transforms/engine/embedding.rs 90.90% <100.00%> (+0.11%) ⬆️
... and 20 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 10, 2025

CodSpeed Performance Report

Merging #172 will not alter performance

Comparing feat/stronger-types-backup (c1c57b3) with main (fd5e8f7)1

Summary

✅ 20 untouched
⏩ 20 skipped2

Footnotes

  1. No successful run was found on main (5590429) during the generation of this report, so fd5e8f7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Contributor

@javiermtorres javiermtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


pub fn embedding_state() -> AppState {
get_state(EMBEDDING_DIR, ModelType::Embedding)
pub fn embedding_state() -> AppState<model_type::Embedding> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to make a general state() delegating to some fn in the trait?

@besaleli besaleli merged commit b201aa0 into main Dec 10, 2025
5 checks passed
@besaleli besaleli deleted the feat/stronger-types-backup branch December 10, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stronger types

4 participants