-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Stronger Types #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Stronger Types #172
Conversation
CodSpeed Performance ReportMerging #172 will not alter performanceComparing Summary
Footnotes
|
javiermtorres
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
|
||
| pub fn embedding_state() -> AppState { | ||
| get_state(EMBEDDING_DIR, ModelType::Embedding) | ||
| pub fn embedding_state() -> AppState<model_type::Embedding> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to make a general state() delegating to some fn in the trait?
No description provided.