Update supported version in SECURITY.md to 0.x.x#27
Conversation
The latest release is v0.1.0, so the supported version pattern should be 0.x.x instead of 0.0.x.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
WalkthroughSECURITY.md was updated to rename repository references to mcpd-sdk-javascript, change supported version entries (0.0.x → 0.1.x supported; 0.0.x not supported), modify reporting form fields, remove public GitHub issue notification, and update scope examples and links for the JavaScript repo (≤50 words). Changes
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
SECURITY.md (2)
19-19:⚠️ Potential issue | 🟡 MinorDuplicate
## Reporting a Vulnerabilitysection heading.The heading at Line 19 is identical to the one at Line 3. This creates two anchors with the same name, which breaks in-page linking (most Markdown renderers will suffix the second with
-1, silently breaking any direct links). The second heading appears to be a structural mistake — the content beneath it (the email address and reporting instructions) logically belongs under the first heading.✏️ Proposed fix — remove the duplicate heading
-## Reporting a Vulnerability - **Please DO NOT open a public GitHub issue.**🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@SECURITY.md` at line 19, Remove the duplicated "## Reporting a Vulnerability" heading (the second occurrence shown in the diff) and attach the email address and reporting instructions currently under that second heading to the original "## Reporting a Vulnerability" section at the top, ensuring there is only one heading and all related content lives beneath it so in-page anchors remain unique.
7-7:⚠️ Potential issue | 🟡 MinorWrong SDK name — this repository is
mcpd-sdk-javascript, notmcpd-sdk-python.Line 7 (and also Lines 27 and 50) all reference
mcpd-sdk-python. This appears to be a copy-paste from the Python SDK's security policy that was never updated. In a security disclosure document, incorrect project names can cause reporters to contact the wrong team or reference the wrong repository.✏️ Proposed fix for all three occurrences
-This document outlines the process for reporting vulnerabilities in `mcpd-sdk-python`. +This document outlines the process for reporting vulnerabilities in `mcpd-sdk-javascript`.-1. **Project Name and Version:** Specify which project (`mozilla-ai/mcpd-sdk-python`) and which version(s) are affected. +1. **Project Name and Version:** Specify which project (`mozilla-ai/mcpd-sdk-javascript`) and which version(s) are affected.-This security policy applies to all components of [mcpd](https://github.com/mozilla-ai/mcpd) (for example, this repository: [mcpd-sdk-python](https://github.com/mozilla-ai/mcpd-sdk-python)). +This security policy applies to all components of [mcpd](https://github.com/mozilla-ai/mcpd) (for example, this repository: [mcpd-sdk-javascript](https://github.com/mozilla-ai/mcpd-sdk-javascript)).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@SECURITY.md` at line 7, Replace all incorrect references to "mcpd-sdk-python" in SECURITY.md with the correct repository name "mcpd-sdk-javascript" (occurrences noted around the current lines that mention the SDK name). Update each mention (the ones at the top, middle, and bottom of the file) so the security policy consistently references mcpd-sdk-javascript and any related context strings are adjusted to match the JavaScript SDK naming.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@SECURITY.md`:
- Line 19: Remove the duplicated "## Reporting a Vulnerability" heading (the
second occurrence shown in the diff) and attach the email address and reporting
instructions currently under that second heading to the original "## Reporting a
Vulnerability" section at the top, ensuring there is only one heading and all
related content lives beneath it so in-page anchors remain unique.
- Line 7: Replace all incorrect references to "mcpd-sdk-python" in SECURITY.md
with the correct repository name "mcpd-sdk-javascript" (occurrences noted around
the current lines that mention the SDK name). Update each mention (the ones at
the top, middle, and bottom of the file) so the security policy consistently
references mcpd-sdk-javascript and any related context strings are adjusted to
match the JavaScript SDK naming.
Using 0.x.x implied backporting security fixes to all minor versions. Scope to just the current minor series (0.1.x) and explicitly mark 0.0.x as unsupported.
Replace mcpd-sdk-python references with mcpd-sdk-javascript and remove the duplicate "Reporting a Vulnerability" heading.
Summary
0.0.xto0.x.xto reflect the latest release (v0.1.0).Test plan
0.0.xrangeSummary by CodeRabbit