feat: add mcpd config volumes list command#249
Conversation
Allow users to list all configured volume mappings for a given MCP server from the runtime context configuration file. Closes #198
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (3)
WalkthroughImplements a new "list" sub-command for the volumes CLI to display volume mappings for a specified MCP server. The command reads runtime configuration, validates server existence, and outputs volumes in a sorted, formatted manner. Sub-command registration order has been adjusted. Changes
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
javiermtorres
left a comment
There was a problem hiding this comment.
Minor suggestion, otherwise lgtm
|
|
||
| out := cobraCmd.OutOrStdout() | ||
|
|
||
| if _, err := fmt.Fprintf(out, "Volumes for '%s':\n", serverName); err != nil { |
There was a problem hiding this comment.
It would be good to use string consts here and reuse them in the tests to avoid false positives, unless we want to verify the string contents themselves.
Summary
mcpd config volumes list <server-name>command to list all user-supplied volume mappings for a given MCP servervolumes setcommand (options pattern,cobra.ExactArgs,OutOrStdout(), sorted output)flags.RuntimeFiledynamically in help text so users see their actual configured pathTest plan
make test)golangci-lint run --fix -v ./cmd/config/volumes/...)Closes #198
Summary by CodeRabbit
New Features
listsub-command to display volume mappings for a specified server. Shows configured volumes in a formatted list, with appropriate messaging for servers without volumes.Tests