Skip to content

fix(control-plane): forward usage.list arguments by keyword - #24

Merged
njbrake merged 1 commit into
mainfrom
fix/endpoint-coverage-drift
Aug 6, 2026
Merged

fix(control-plane): forward usage.list arguments by keyword#24
njbrake merged 1 commit into
mainfrom
fix/endpoint-coverage-drift

Conversation

@njbrake

@njbrake njbrake commented Aug 6, 2026

Copy link
Copy Markdown
Member

Note: this PR was drafted by Claude via back-and-forth with @njbrake. The reasoning and decisions are his; the prose is Claude's.

Unblocks CI, which is currently failing on main as well as on the open SDK regen PR (mozilla-ai/otari#438). Three independent fixes:

usage.list now forwards by keyword. The regenerated core inserts 11 query-filter params into list_usage_v1_usage_get between user_id and skip. The positional call silently bound skip to status and limit to status_code; strict mypy catches it, but untyped callers would not. Behavior on the current core is unchanged, so this is safe to land ahead of the regen. Added a test that pins keyword delegation.

Dropped an unused # noqa: S310. ruff 0.16 no longer flags that call, so RUF100 fails the lint step. This was masking the mypy error above, since Lint runs before Type check in the same job.

Endpoint-coverage manifest. The gate fetches otari main's live spec at test time, so it re-evaluates every run; 26 endpoints added since the manifest was last touched were in neither section. All 26 go under [excluded]: session auth and OTLP ingest with permanent reasons, the other 22 as # not yet wrapped. Kept identical across all four SDKs.

Note: 17 other aliases (list_keys, list_users, list_budgets, list_pricing) still delegate positionally and carry the same latent bug if those endpoints gain filters. Left alone here to keep the change targeted.

@njbrake
njbrake merged commit c7ac8eb into main Aug 6, 2026
3 checks passed
@njbrake
njbrake deleted the fix/endpoint-coverage-drift branch August 6, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant