Bug 1429344 - Review requests in requests dropdown should link to MozReview or GitHub instead of Bugzilla details page

[kyoshino]

Fix Bug 1429344 - Review requests in requests dropdown should link to MozReview or GitHub instead of Bugzilla details page

Description

• Retrieve attachments.mimetype from DB as attach_mimetype
• Retrieve attachments.ispatch from DB as attach_ispatch instead of ispatch for consistency (this field is not used in other templates so the change should be safe)
• Treat MozReview and Phabricator requests as patches
• Support GitHub pull requests and Google Docs as well
• Link directly to those external sites
• For regular patches, link to the Splinter Review page if available

[dylanwh]

requests.cgi is pretty nightmareish code. I can't even begin to understand why it is using positional rows and not using the type of $dbi->select that uses column names.

I'll write a new backend that is also performant.

[kyoshino]

Ah, one thing I've noticed is that the splinter review URL page.cgi?id=splinter.html is customizable by admin. To avoid any potential breakage in the future or upstream, it has to be exposed as a string in the template like the extension list also added in this PR.

[kyoshino]

Instead of an extension list, exposed the splinter_base param in the template so review links always work.

[dylanwh]

doesn't this need to also group by ispatch?

[kyoshino]

There's already ispatch 2 lines above. Looks like it's a duplicate, so just changing it to mimetype.