Clean code

tests/pulse_utils.py

@@ -70,7 +70,6 @@ def send_pulse_message(pulse_config, payload, purge=False):
 
 if __name__ == "__main__":
     config = Config.from_file(HERE.parent / "config.toml")
-    config.mappings
     message_type = sys.argv[1]
     match message_type:
         case "push":

tests/test_integration.py

@@ -6,11 +6,12 @@
 import pytest
 from git import Repo
 from mozlog import get_proxy_logger
+from utils import hg_export_tip
 
 from git_hg_sync.__main__ import get_connection, get_queue, start_app
 from git_hg_sync.config import Config
 
-NO_RABBITMQ = not (os.getenv("RABBITMQ") == "true")
+NO_RABBITMQ = not os.getenv("RABBITMQ") == "true"
 HERE = Path(__file__).parent
 
 
@@ -77,12 +78,5 @@ def test_full_app(
     # execute app
     start_app(config, get_proxy_logger("test"), one_shot=True)
 
-    # tests
-    process = subprocess.run(
-        ["hg", "export", "tip"],
-        cwd=hg_remote_repo_path,
-        check=True,
-        capture_output=True,
-        text=True,
-    )
-    assert "FOO CONTENT" in process.stdout
+    # test
+    assert "FOO CONTENT" in hg_export_tip(hg_remote_repo_path)

tests/test_repo_synchronizer.py

@@ -3,6 +3,7 @@
 
 import pytest
 from git import Repo
+from utils import hg_export_tip
 
 from git_hg_sync.__main__ import get_connection, get_queue
 from git_hg_sync.config import TrackedRepository
@@ -41,14 +42,8 @@ def test_sync_process_(
     syncrepos = RepoSynchronizer(git_local_repo_path, str(git_remote_repo_path))
     syncrepos.sync_branches(str(hg_remote_repo_path), [(git_commit_sha, "foo")])
 
-    process = subprocess.run(
-        ["hg", "export", "tip"],
-        cwd=hg_remote_repo_path,
-        check=True,
-        capture_output=True,
-        text=True,
-    )
-    assert "FOO CONTENT" in process.stdout
+    # test
+    assert "FOO CONTENT" in hg_export_tip(hg_remote_repo_path)
 
 
 def test_get_connection_and_queue(pulse_config):

tests/utils.py

@@ -0,0 +1,12 @@
+import subprocess
+
+
+def hg_export_tip(repo_path: str):
+    process = subprocess.run(
+        ["hg", "export", "tip"],
+        cwd=repo_path,
+        check=True,
+        capture_output=True,
+        text=True,
+    )
+    return process.stdout