fix: Github app pem needs to have proper newlines before creating jwt#15
Merged
fix: Github app pem needs to have proper newlines before creating jwt#15
Conversation
There was a problem hiding this comment.
Pull request overview
Normalizes the GITHUB_PRIVATE_KEY environment variable so GitHub App PEM keys stored with escaped newlines (\\n) are converted to real newlines before JWT signing, improving reliability in Docker/CI deployments.
Changes:
- Convert escaped newline sequences (
\\n) inGITHUB_PRIVATE_KEYto actual newlines prior to authentication setup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cgsheeh
approved these changes
Mar 24, 2026
Member
cgsheeh
left a comment
cgsheeh
left a comment
There was a problem hiding this comment.
Adding a test for this would be ideal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.