Include bug id in /revisions/{id} API response #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our phabricator extensions inject the bugzilla bug id on the revisions retrieved via the api. It makes sense to pass this along through Lando API.
Apparently, Phabricator revisions can be tied to no repository. This commit makes sure that we take that into account.
zalun
approved these changes
Jun 19, 2017
Contributor
zalun
left a comment
zalun
left a comment
There was a problem hiding this comment.
Approved, it would be good to have a test with no bug id, to prove it's not failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our phabricator extensions inject the bugzilla bug id on the revisions retrieved via the api. It makes sense to pass this along through Lando API.
Also: prevent crash when Phabricator revision has no repository. Apparently, Phabricator revisions can be tied to no repository. This commit makes sure that we take that into account.