requirements: pin requirements explicity in requirements.in (Bug 1824006)#293
Merged
cgsheeh merged 2 commits intomozilla-conduit:mainfrom Mar 27, 2023
Merged
requirements: pin requirements explicity in requirements.in (Bug 1824006)#293cgsheeh merged 2 commits intomozilla-conduit:mainfrom
requirements.in (Bug 1824006)#293cgsheeh merged 2 commits intomozilla-conduit:mainfrom
Conversation
…24006) Each of the added requirements is used at least once in Lando's core codebase.
zzzeid
requested changes
Mar 27, 2023
Contributor
zzzeid
left a comment
zzzeid
left a comment
There was a problem hiding this comment.
You should run build-requirements since there are packages now that are sourced from requirements.in vs. as dependencies of other packages, thus requirements.txt is no longer accurate.
zzzeid
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each of the added requirements is used at least once in Lando's
core codebase.