configuration, admin: ConfigurationVariable improvements (bug 2011883)#869
Draft
configuration, admin: ConfigurationVariable improvements (bug 2011883)#869
Conversation
|
View this pull request in Lando to land it once approved. |
zzzeid
changed the title
cgsheeh
reviewed
Jan 30, 2026
| ): | ||
| # Use the existing ConfigurationVariable API to ensure field is | ||
| # set and cleaned correctly. | ||
| ConfigurationVariable.set(**form.cleaned_data) |
Member
There was a problem hiding this comment.
If you cast the key value to a ConfigurationKey here you can avoid most of the key_value related changes, since you won't need to support arbitrary str inputs. This would also avoid issues with typos on expected key values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.