Bug 1955371: Add User-Agent to outgoing requests #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump for psycopg/psycopg2#1397 * Rebuild requirements.txt with pip-compile
* Bump to fix `ImportError: cannot import name _unicodefun from click` * Rebuild requirements.txt with pip-compile --generate-hashes --upgrade
cgsheeh
approved these changes
Mar 21, 2025
| import pathlib | ||
| from dataclasses import dataclass | ||
| from typing import Protocol, Dict | ||
| from typing import Optional, Protocol, Dict |
Member
There was a problem hiding this comment.
Off topic: we should get our usual combination of ruff/black running on this repo at some point, for import sorting etc. :)
Member
Author
There was a problem hiding this comment.
It's got black running in the tests https://github.com/mozilla-conduit/phabricator-emails/blob/master/tests/test_style.py#L16-L17
This code base hasn't been touched in a while (:
| try: | ||
| # Use POST instead of GET so that the conduit token isn't part of the URL | ||
| result = requests.post(url, data=body) | ||
| result = self._session.post(url, data=body) |
Member
There was a problem hiding this comment.
Alternatively you could just add the headers to post here, without managing a session, but this LGTM.
zzzeid
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.