PhabricatorRepositoryCommitPublishWorker: move relevance logic (bug 1963406) #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move repository matching check to PhabricatorRepositoryCommitPublishWorker Prior to this change, a commit that matches a revision was still going through code in both PhabricatorRepositoryCommitPublishWorker and DiffusionUpdateObjectAfterCommitWorker that was making changes to the revision other than changin the status. With this change, the revisions will still show a link to the commit, however none of the code in DiffusionUpdateObjectAfterCommitWorker will be triggered.
zzzeid
changed the title
dklawren
approved these changes
Jul 23, 2025
zzzeid
deleted the
zeid-bug-1963406-do-not-associate-revisions-with-different-repos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, a commit that matches a revision was still going through code in both PhabricatorRepositoryCommitPublishWorker and DiffusionUpdateObjectAfterCommitWorker that was making changes to the revision other than changing the status. With this change, the revisions will still show a link to the commit, however none of the code in DiffusionUpdateObjectAfterCommitWorker will be triggered.