Skip to content

Bug 2030079: Fix intermittent test failure.#240

Closed
pollym wants to merge 1 commit intomozilla-firefox:autolandfrom
pollym:fix-intermittent-gamestate-test-issue-2030079
Closed

Bug 2030079: Fix intermittent test failure.#240
pollym wants to merge 1 commit intomozilla-firefox:autolandfrom
pollym:fix-intermittent-gamestate-test-issue-2030079

Conversation

@pollym
Copy link
Copy Markdown
Contributor

@pollym pollym commented Apr 30, 2026

This test was non-deterministic - it went:

  • place food
  • have the fox eat the food
  • respawn the food in a random place
  • check that the food is in a different place now

But there was a chance the food would respawn in the same place again (: This can be fixed by initially placing the food outside of the area where it can spawn. There is a "safe zone" for that right up against the walls, because food doesn't naturally spawn there (it makes the game quite annoying to play if it does)

This test was non-deterministic - it went:
- place food
- have the fox eat the food
- respawn the food in a random place
- check that the food is in a different place now

But there was a chance the food would respawn in the same place again (:
This can be fixed by initially placing the food outside of the area where it can spawn. There is a "safe zone" for that right up against the walls, because food doesn't naturally spawn there (it makes the game quite annoying to play if it does)
@github-actions
Copy link
Copy Markdown
Contributor

View this pull request in Lando to land it once approved.

@pollym
Copy link
Copy Markdown
Contributor Author

pollym commented Apr 30, 2026

here is a try

Copy link
Copy Markdown

@AndreyZIno AndreyZIno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lando-worker
Copy link
Copy Markdown

lando-worker Bot commented May 1, 2026

Pull request closed by commit 2b1ba2f

lando-worker Bot pushed a commit that referenced this pull request May 1, 2026
This test was non-deterministic - it went:
- place food
- have the fox eat the food
- respawn the food in a random place
- check that the food is in a different place now

But there was a chance the food would respawn in the same place again (: This can be fixed by initially placing the food outside of the area where it can spawn. There is a "safe zone" for that right up against the walls, because food doesn't naturally spawn there (it makes the game quite annoying to play if it does)

Pull request: #240
@lando-worker lando-worker Bot closed this May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants