This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Conversation
src/manifest.json.tpl
Outdated
| "gecko": { | ||
| "id": "{{id}}", | ||
| "strict_min_version": "67.0", | ||
| "strict_max_version": "69.0", |
Contributor
There was a problem hiding this comment.
I believe this should be "69.*" to handle the dot-releases
jaredhirsch
reviewed
Jul 30, 2019
| @@ -3,7 +3,7 @@ | |||
| "name": "lockwise", | |||
| "id": "lockbox@mozilla.com", | |||
| "version": "2.2.4-alpha", | |||
Contributor
There was a problem hiding this comment.
I'm not sure if manifest changes will be applied for existing users unless you bump the version number.
Contributor
Author
There was a problem hiding this comment.
it won't. I wanted to get this mechanics done first, then do an actual release (including the latest from pontoon).
|
Any update here? @linuxwolf |
Contributor
Author
|
At least from local testing, this is doing what's asked, so merging. Will then stage a releas with the latest updates from Pontoon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change, combined with an update to the updates manifest, defers to the built-in functionality in Firefox 70.
See BMO 1560608
Connected to #188
Connected to mozilla-lockwise/mozilla-lockwise.github.io#138
Testing and Review Notes
This add-on should no longer install on Firefox versions 70 or higher.
To Do