Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Don't show [Advanced..] button on HTTPS error when on ErrorType.ERROR_SECURITY_SSL #10588

@makotokato

Description

@makotokato

Original issue is mozilla-mobile/fenix#18441.

Actually, components/browser/errorpages/src/main/java/mozilla/components/browser/errorpages/ErrorPages.kt shows [Advanced...] button on HTTPS error when error is ErrorType.ERROR_SECURITY_SSL or ErrorType.ERROR_SECURITY_BAD_CERT.

When error is ErrorType.ERROR_SECURITY_BAD_CERT, it is overridable. But ErrorType.ERROR_SECURITY_SSL isn't overridable. (See https://bugzilla.mozilla.org/show_bug.cgi?id=1696841#c11 and https://bugzilla.mozilla.org/show_bug.cgi?id=1696841#c12). So we shouldn't show [Adavaned..] button on ErrorType.ERROR_SECURITY_SSL.

┆Issue is synchronized with this Jira Task

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions