This repository was archived by the owner on Nov 1, 2022. It is now read-only.
Prepend 'http' to URLs in intents whith no schemes #11093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We observed via Sentry that we were hitting a bunch of 'url without base' exceptions coming out of metadata observation API. One of these cases where we'll end-up trying to process a URL without a base (e.g. without a scheme) is when we're processing external intent and see something like "example.com", instead of "https://example.com". In our toolbar, we use String.toNormalizedUrl to handle this case. In this patch, we now do the same for URLs we encounter in external intents, as well.
grigoryk
requested review from
a team,
Amejia481 and
jonalmeida
as code owners
Contributor
Author
pocmo
approved these changes
Oct 6, 2021
components/support/ktx/src/main/java/mozilla/components/support/ktx/kotlin/String.kt
Show resolved
Hide resolved
csadilek
approved these changes
Oct 6, 2021
Contributor
|
@Mergifyio backport releases/94.0 |
Contributor
|
Command
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed via Sentry that we were hitting a bunch of 'url without
base' exceptions coming out of metadata observation API. One of these
cases where we'll end-up trying to process a URL without a base (e.g.
without a scheme) is when we're processing external intent and see
something like "example.com", instead of "https://example.com".
In our toolbar, we use String.toNormalizedUrl to handle this case.
In this patch, we now do the same for URLs we encounter in external
intents, as well.
Pull Request checklist
After merge