Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Conversation

@grigoryk
Copy link
Contributor

Some low-hanging fruit for #7034


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@grigoryk
Copy link
Contributor Author

These few commits get us to 4023 tasks created during config phase, vs current baseline of 23519.

@grigoryk
Copy link
Contributor Author

... and a few more shaved off, to 3749.

@grigoryk grigoryk force-pushed the gradleLazyTasks1 branch from 09155a8 to 97778c3 Compare May 20, 2020 03:05
@grigoryk
Copy link
Contributor Author

grigoryk commented May 20, 2020

Seems like I broke something, from toolchain-linux64-android-gradle-dependencies on CI:

[task 2020-05-20T03:08:15.654Z] Build file '/builds/worker/checkouts/src/build.gradle' line: 103
[task 2020-05-20T03:08:15.654Z] 
[task 2020-05-20T03:08:15.654Z] * What went wrong:
[task 2020-05-20T03:08:15.654Z] Could not determine the dependencies of task ':ui-icons:parseReleaseLibraryResources'.
[task 2020-05-20T03:08:15.654Z] > Could not create task ':ui-icons:packageReleaseResources'.
[task 2020-05-20T03:08:15.654Z]    > Cannot change dependencies of configuration ':ui-icons:androidApis' after task dependencies have been resolved

to be continued soon!

@grigoryk grigoryk changed the title For #7034: lazily register clean/detekt/ktlint/coverage tasks For #7034: Task configuration avoidance improvements May 20, 2020
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #7036 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7036      +/-   ##
============================================
- Coverage     77.02%   76.97%   -0.06%     
+ Complexity     4885     4652     -233     
============================================
  Files           651      621      -30     
  Lines         24098    22999    -1099     
  Branches       3538     3398     -140     
============================================
- Hits          18562    17703     -859     
+ Misses         4052     3880     -172     
+ Partials       1484     1416      -68     
Impacted Files Coverage Δ Complexity Δ
...search/provider/localization/SearchLocalization.kt
...la/components/browser/search/suggestions/Parser.kt
...a/mozilla/components/lib/crash/db/CrashDatabase.kt
...a/components/browser/search/SearchEngineManager.kt
...wser/search/provider/AssetsSearchEngineProvider.kt
...ava/mozilla/components/lib/crash/db/CrashEntity.kt
...ozilla/components/lib/crash/db/CrashWithReports.kt
...zilla/components/lib/crash/ui/CrashListFragment.kt
...r/localization/LocaleSearchLocalizationProvider.kt
...onents/lib/crash/notification/CrashNotification.kt
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde63c0...47234b1. Read the comment docs.

@grigoryk
Copy link
Contributor Author

Green CI! I think that means this can land.

Copy link
Contributor

@NotWoods NotWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've testing building with this config and with similar changes in Fenix, should be good

@grigoryk
Copy link
Contributor Author

bors r=NotWoods

@bors
Copy link

bors bot commented May 22, 2020

Build succeeded:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants