Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Conversation

@gabrielluong
Copy link
Member

@gabrielluong gabrielluong commented May 31, 2020


Fixes #7194. For ContextualIdentityStorage.addContextualIdentity, I will note that I followed the API of contextualIdentities.create() since this is what most web extensions care about.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@gabrielluong gabrielluong force-pushed the contextualidentities branch from 117b4de to bd8f3c0 Compare May 31, 2020 18:04
@gabrielluong gabrielluong requested a review from pocmo May 31, 2020 18:07
@gabrielluong gabrielluong changed the title Issue #7194: Create a Contextual Identity Storage component 🕹 Issue #7194: Create a Contextual Identity Storage component May 31, 2020
@gabrielluong gabrielluong changed the title 🕹 Issue #7194: Create a Contextual Identity Storage component Issue #7194: Create a Contextual Identity Storage component May 31, 2020
@gabrielluong gabrielluong reopened this May 31, 2020
@gabrielluong gabrielluong reopened this May 31, 2020
@gabrielluong gabrielluong reopened this Jun 1, 2020
@gabrielluong gabrielluong force-pushed the contextualidentities branch from bd8f3c0 to 05e103e Compare June 1, 2020 15:52
@gabrielluong
Copy link
Member Author

Ah seems like CI doesn't like the component naming:

RuntimeError: Treeherder group and symbol names must not be longer than 25 characters: feature-contextualidentities(BN) (see https://github.com/taskcluster/taskcluster-treeherder/blob/master/schemas/task-treeherder-config.yml)

@gabrielluong
Copy link
Member Author

gabrielluong commented Jun 1, 2020

  • I am going to move this over to a browser component after talking with @jonalmeida since this is a component of a browser over a feature on its own.

@gabrielluong
Copy link
Member Author

gabrielluong commented Jun 1, 2020

Ah seems like CI doesn't like the component naming:

RuntimeError: Treeherder group and symbol names must not be longer than 25 characters: feature-contextualidentities(BN) (see https://github.com/taskcluster/taskcluster-treeherder/blob/master/schemas/task-treeherder-config.yml)

  • Also, considering renaming this to browser-containers to get over the RuntimeError.

@gabrielluong
Copy link
Member Author

gabrielluong commented Jun 1, 2020

@gabrielluong gabrielluong force-pushed the contextualidentities branch 2 times, most recently from 3073d67 to baae29a Compare June 2, 2020 05:20
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #7195 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7195      +/-   ##
============================================
- Coverage     77.35%   77.14%   -0.22%     
+ Complexity     5056     4871     -185     
============================================
  Files           674      654      -20     
  Lines         24736    23399    -1337     
  Branches       3655     3497     -158     
============================================
- Hits          19134    18050    -1084     
+ Misses         4089     3917     -172     
+ Partials       1513     1432      -81     
Impacted Files Coverage Δ Complexity Δ
...ture/addons/ui/UnsupportedAddonsAdapterDelegate.kt
.../mozilla/components/lib/nearby/NearbyConnection.kt
...ts/feature/addons/update/db/UpdateAttemptEntity.kt
...a/components/feature/addons/ui/CustomViewHolder.kt
...feature/addons/migration/SupportedAddonsChecker.kt
...ozilla/components/feature/addons/AddonsProvider.kt
.../mozilla/components/feature/addons/AddonManager.kt
...ure/addons/update/GlobalAddonDependencyProvider.kt
...a/components/feature/addons/update/AddonUpdater.kt
...lla/components/feature/addons/worker/Extensions.kt
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebec562...17648f4. Read the comment docs.

@gabrielluong gabrielluong changed the title Issue #7194: Create a Contextual Identity Storage component Issue #7194: Create a Browser Containers component Jun 2, 2020
@gabrielluong gabrielluong force-pushed the contextualidentities branch 2 times, most recently from f7847d9 to 1fd0a62 Compare June 2, 2020 14:55
@gabrielluong gabrielluong force-pushed the contextualidentities branch from 1fd0a62 to 0b302e6 Compare June 9, 2020 04:04
@gabrielluong gabrielluong force-pushed the contextualidentities branch from 0b302e6 to 17648f4 Compare June 9, 2020 16:09
@gabrielluong
Copy link
Member Author

bors r=pocmo

@bors
Copy link

bors bot commented Jun 9, 2020

Build succeeded:

@bors bors bot merged commit 6699783 into mozilla-mobile:master Jun 9, 2020
@gabrielluong gabrielluong deleted the contextualidentities branch June 9, 2020 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a Browser Containers component

3 participants