Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented Aug 10, 2020

This was scraped from the linked data reviews.


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

This was scraped from the linked data reviews.
@psymoon psymoon self-requested a review August 10, 2020 17:36
@psymoon psymoon self-assigned this Aug 10, 2020
@psymoon
Copy link
Contributor

psymoon commented Aug 10, 2020

@mdboom does this need data review?

@mdboom
Copy link
Contributor Author

mdboom commented Aug 10, 2020

@mdboom does this need data review?

I don't think so -- it's just moving information already in data reviews to a more structured form. But let me ping a data reviewer (@chutten) for confirmation.

@mdboom mdboom changed the title Bug 1608838: Add data sensitibity category metadata Bug 1608838: Add data sensitivity category metadata Aug 10, 2020
@chutten
Copy link

chutten commented Aug 10, 2020

No Data Review required. The data collections being modified aren't being expanded or added to, just their metadata being trimmed up.

@psymoon
Copy link
Contributor

psymoon commented Aug 10, 2020

bors r+

@bors
Copy link

bors bot commented Aug 10, 2020

Build succeeded:

@bors bors bot merged commit 2f3904e into mozilla-mobile:master Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants