This repository was archived by the owner on Nov 1, 2022. It is now read-only.
[donotland] A-S update helper workflow #9417
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugurell
added a commit
to Mugurell/android-components
that referenced
this pull request
Jan 22, 2021
Prior to this when the user selected to share an image from the contextual menu the apps would only share the URL, not the actual resource. This patch adds a new `ShareDownloadFeature` that will listen for `AddShareAction` and download, cache locally and then share the Internet resource contained in Action's state. Giving the time needed to actually download these resources this feature is only used for image sharing, not for other types of potentially bigger resource types. This is a breaking change with clients expected to create and register a new instance of the this new feature otherwise the "Share image" from the browser contextual menu will do nothing.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this pull request
Jan 28, 2021
Prior to this when the user selected to share an image from the contextual menu the apps would only share the URL, not the actual resource. This patch adds a new `ShareDownloadFeature` that will listen for `AddShareAction` and download, cache locally and then share the Internet resource contained in Action's state. Giving the time needed to actually download these resources this feature is only used for image sharing, not for other types of potentially bigger resource types. This is a breaking change with clients expected to create and register a new instance of the this new feature otherwise the "Share image" from the browser contextual menu will do nothing.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this pull request
Jan 29, 2021
Prior to this when the user selected to share an image from the contextual menu the apps would only share the URL, not the actual resource. This patch adds a new `ShareDownloadFeature` that will listen for `AddShareAction` and download, cache locally and then share the Internet resource contained in Action's state. Giving the time needed to actually download these resources this feature is only used for image sharing, not for other types of potentially bigger resource types. This is a breaking change with clients expected to create and register a new instance of the this new feature otherwise the "Share image" from the browser contextual menu will do nothing.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this pull request
Feb 1, 2021
Prior to this when the user selected to share an image from the contextual menu the apps would only share the URL, not the actual resource. This patch adds a new `ShareDownloadFeature` that will listen for `AddShareAction` and download, cache locally and then share the Internet resource contained in Action's state. Giving the time needed to actually download these resources this feature is only used for image sharing, not for other types of potentially bigger resource types. This is a breaking change with clients expected to create and register a new instance of the this new feature otherwise the "Share image" from the browser contextual menu will do nothing.
mergify bot
added a commit
that referenced
this pull request
Feb 1, 2021
Prior to this when the user selected to share an image from the contextual menu the apps would only share the URL, not the actual resource. This patch adds a new `ShareDownloadFeature` that will listen for `AddShareAction` and download, cache locally and then share the Internet resource contained in Action's state. Giving the time needed to actually download these resources this feature is only used for image sharing, not for other types of potentially bigger resource types. This is a breaking change with clients expected to create and register a new instance of the this new feature otherwise the "Share image" from the browser contextual menu will do nothing. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge