Integrate the history tracking and storage components. #40
Conversation
|
|
||
| historyTrackingFeature = HistoryTrackingFeature( | ||
| requireComponents.engine, | ||
| requireComponents.historyStorage) |
There was a problem hiding this comment.
I assume this is more like an "application level" feature and we would want to create this in BrowserApplication.onCreate() so that we track history even when there's no fragment/UI around. (cc @grigoryk)
There was a problem hiding this comment.
I'm not sure what "tracking history without a browser fragment/ui around" means, but generally I agree, history tracking isn't conceptually tied to the UI, so moving this over to BrowserApplication makes sense.
Separately, we'd want to make that change in the sample-browser as well.
There was a problem hiding this comment.
I'm not sure what "tracking history without a browser fragment/ui around" means
We are able to load URLs while the app is in the background and while there may not be any UI (but we still want to record history). Fragments come and go. There's no reason we want to re-register a new delegate whenever there's a new BrowserFragment getting created.
|
This will fix #89. ✨ |
|
|
||
| historyTrackingFeature = HistoryTrackingFeature( | ||
| requireComponents.engine, | ||
| requireComponents.historyStorage) |
There was a problem hiding this comment.
I'm not sure what "tracking history without a browser fragment/ui around" means, but generally I agree, history tracking isn't conceptually tied to the UI, so moving this over to BrowserApplication makes sense.
Separately, we'd want to make that change in the sample-browser as well.
|
Now that mozilla-mobile/android-components#1164 landed and released in 0.30, this can be backed by Rust Places instead of an in-memory storage. |
|
To avoid creating a new issue, @linacambridge could you update this to use |
Amejia481
changed the title
|
Closing in favor of #184. |
3 participants
Cargo-culting @grigoryk's changes for the sample browser in mozilla-mobile/android-components#1155 to use in-memory history storage. 😸