Reduce the overscan used for VariableSizeList
#3590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ac4ea53 I changed it from 5 to 20 because I think I had issues with the element sizing during dev and I had figured that the overscan might have been the culprit. And because everything was working, I kept it there. Fast forward to me testing the rules page with 10k items... Reducing the overscan from 20 to 5 makes the page go from sluggish to scroll to smooth. Turns out rendering the rule cards is expensive. It's definitely not necessary to have such a large overscan so I see no drawbacks to doing this.
jcristau
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ac4ea53 I changed it from 5 to 20 because I think I had issues with the element sizing during dev and I had figured that the overscan might have been the culprit. And because everything was working, I kept it there. Fast forward to me testing the rules page with 10k items... Reducing the overscan from 20 to 5 makes the page go from sluggish to scroll to smooth. Turns out rendering the rule cards is expensive. It's definitely not necessary to have such a large overscan so I see no drawbacks to doing this.