Use Phabricator build target PHID when triggering code-review hook#278
Merged
jcristau merged 1 commit intomozilla-releng:mainfrom Feb 6, 2025
Merged
Conversation
Contributor
|
Can this land whenever or does it need to wait until some other parts are merged/deployed? |
Contributor
Author
|
You can land whenever, this only affects testing instance (no traffic whatsoever). |
jcristau
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the payload required to trigger the hook with a token, as Phabricator will now directly call
triggerHookWithTokenand provides the build target PHID (instead of the webhook trigger payload).The build plan is pending deployment on phabricator-dev: https://bugzilla.mozilla.org/show_bug.cgi?id=1935142#c24
A PR is also pending review on the bot to support the new environment variable mozilla/code-review#2611