Conversation
hneiva
force-pushed
the
hneiva/mac-signing
branch
4 times, most recently
from
ab1bcd8 to
d5c7daf
Compare
bhearsum
approved these changes
Nov 14, 2023
Contributor
bhearsum
left a comment
bhearsum
left a comment
There was a problem hiding this comment.
Looks good overall, thank you! One minor nit for this doc, and one enhancement request for elsewhere noted below.
| - `manual rollout <https://github.com/mozilla-releng/scriptworker-scripts/wiki/manual-rollout>`__ for dep, until `bug 1648845 <https://bugzilla.mozilla.org/show_bug.cgi?id=1648845>`__ is fixed. | ||
| - `mac maintenance <https://github.com/mozilla-releng/scriptworker-scripts/wiki/mac-maintenance>`__ for how to update deps, restart scriptworker, and wipe machines. | ||
|
|
||
| General notarization workflow (DEPRECATED) |
Contributor
There was a problem hiding this comment.
Can you add a note here to remove this section after esr115 goes away?
| Certificates | ||
| ------------ | ||
|
|
||
| For certificate rotation, see the signing page in `RelEng Confluence space <https://mozilla-hub.atlassian.net/wiki/spaces/RelEng/overview>`__. |
Contributor
There was a problem hiding this comment.
Please update that wiki page to talk about how to rotate provisioning profiles at well, since it is now a required part of certificate rotation.
hneiva
force-pushed
the
hneiva/mac-signing
branch
from
d5c7daf to
b08cca9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.