move GithubClient to scriptworker_client; add support for slashes in key names #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhearsum
force-pushed
the
move-github-client
branch
3 times, most recently
from
18e4207 to
9df02c4
Compare
…key names A few things going on here, mostly boring: * Move the existing GithubClient to scriptworker_client * Move the associated test fixtures to a new `pytest-scriptworker-client` package * Necessary adjustments in treescript to let it be able to find and use the new packages Although not ideal, this also includes a minor fix to allow slashes in GraphQL key names that I had already incorporated into the version of this code in mozilla-releng#1135. I can pull it out if necessary, but I think it's probably small and safe enough to just keep in here?
bhearsum
force-pushed
the
move-github-client
branch
from
9df02c4 to
b8ee60c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things going on here, mostly boring:
pytest-scriptworker-clientpackageAlthough not ideal, this also includes a minor fix to allow slashes in GraphQL key names that I had already incorporated into the version of this code in #1135. I can pull it out if necessary, but I think it's probably small and safe enough to just keep in here?
This is all motivated by the fact that Landoscript needs a GithubClient, and we ought to share the existing one between it and treescript.