fix(landoscript): check all android toml files at one time, before pr… #1165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jcristau
reviewed
Apr 18, 2025
Comment on lines
246
to
245
| # done here because setup_test sets up github_installation_response too soon...argh | ||
| from yarl import URL |
Contributor
There was a problem hiding this comment.
Was the comment meant to go with the removed line? (either way, seems unrelated with this patch?)
Contributor
Author
There was a problem hiding this comment.
The comment is about repeating all of the test set up overall (instead of using setup_test), but I can see how it is...not particularly great. I'll improve it.
The import change is unrelated, yeah. It's not harmful, but I'll revert it to keep things clean. (Another follow up I'm planning is to add isort, which will help clean some of these things up.)
| @@ -1,6 +1,7 @@ | |||
| import pytest | |||
| from scriptworker_client.github_client import TransportQueryError | |||
| from yarl import URL | |||
Contributor
Author
There was a problem hiding this comment.
Yeah. The removal is removing an unused import, but as you say, unrelated.
bhearsum
force-pushed
the
lando-toml-contents
branch
from
1a8711e to
18b4fea
Compare
jcristau
approved these changes
Apr 22, 2025
bhearsum
force-pushed
the
lando-toml-contents
branch
from
18b4fea to
7ec66bb
Compare
…ocessing any of them This is a follow to address something [@ahal called out in the initial review of landoscript](mozilla-releng#1135 (comment)).
bhearsum
force-pushed
the
lando-toml-contents
branch
from
7ec66bb to
a5877b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ocessing any of them
This is a follow to address something @ahal called out in the initial review of landoscript.